cifs: Fix potential deadlock when updating vol in cifs_reconnect()

Browse source

We can't acquire volume lock while refreshing the DFS cache because
cifs_reconnect() may call dfs_cache_update_vol() while we are walking
through the volume list.

To prevent that, make vol_info refcounted, create a temp list with all
volumes eligible for refreshing, and then use it without any locks
held.

Besides, replace vol_lock with a spinlock and protect cache_ttl from
concurrent accesses or changes.

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>

...

This commit is contained in:

Paulo Alcantara (SUSE) 2019-12-04 17:38:02 -03:00 • committed by Steve French

parent ff2f7fc082

commit 06d57378bc

1 changed files with 77 additions and 32 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

109

fs/cifs/dfs_cache.c

View file