drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt, v2

Browse source

An HPD interrupt may fire while we are in a function that changes
the PORT_HOTPLUG_EN register - especially when an HPD interrupt
storm occurs.
Since the interrupt handler changes the enabled HPD lines when it
detects such a storm the read-modify-write cycles may interfere.
To avoid this, shiled the rmw cycles with IRQ save spinlocks.

Changes since v1:
- Implement a function which takes care of accessing PORT_HOTPLUG_EN.

Signed-off-by: Egbert Eich <eich@suse.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Egbert Eich 2015-09-23 16:15:27 +02:00 • committed by Daniel Vetter

parent 8204502a6a

commit 0706f17c30

3 changed files with 59 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/i915_drv.h

View file

64

drivers/gpu/drm/i915/i915_irq.c

View file

11

drivers/gpu/drm/i915/intel_crt.c

View file