Revert "btrfs: turn delayed_nodes_tree into an XArray"

Browse source

This reverts commit 253bf57555.

Revert the xarray conversion, there's a problem with potential
sleep-inside-spinlock [1] when calling xa_insert that triggers GFP_NOFS
allocation. The radix tree used the preloading mechanism to avoid
sleeping but this is not available in xarray.

Conversion from spin lock to mutex is possible but at time of rc6 is
riskier than a clean revert.

[1] https://lore.kernel.org/linux-btrfs/cover.1657097693.git.fdmanana@suse.com/

Reported-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

...

This commit is contained in:

David Sterba 2022-07-15 13:59:45 +02:00

parent 5b8418b843

commit 088aea3b97

4 changed files with 50 additions and 44 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

fs/btrfs/ctree.h

View file

84

fs/btrfs/delayed-inode.c

View file

2

fs/btrfs/disk-io.c

View file

2

fs/btrfs/inode.c

View file