net/mlx5e: Replace synchronize_rcu with synchronize_net

Browse source

[ Upstream commit 4d6e6b0c6d ]

The commit cited below switched from using napi_synchronize to
synchronize_rcu to have a guarantee that it will finish in finite time.
However, on average, synchronize_rcu takes more time than
napi_synchronize. Given that it's called multiple times per channel on
deactivation, it accumulates to a significant amount, which causes
timeouts in some applications (for example, when using bonding with
NetworkManager).

This commit replaces synchronize_rcu with synchronize_net, which is
faster when called under rtnl_lock, allowing to speed up the described
flow.

Fixes: 9c25a22dfb ("net/mlx5e: Use synchronize_rcu to sync with NAPI")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Maxim Mikityanskiy 2021-02-01 14:01:27 +02:00 • committed by Greg Kroah-Hartman

parent 27c79b3a92

commit 08b42b6f89

4 changed files with 7 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/mellanox/mlx5/core/en/xdp.h

View file

2

drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c

View file

2

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

View file

8

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

View file