drm/i915: add port parameter to intel_hdmi_init

Browse source

Instead of having a giant if cascade to figure this out according to
the passed-in register. We could do quite a bit more cleaning up and
all by using the port at more places, but I think this should be part
of a bigger rework to introduce a struct intel_digital_port which
would keep track of all these things. I guess this will be part of
some haswell-DP-induced refactoring.

For now this rips out the big cascade, which is what annoyed me so
much.

v2: Add port variable name back for the func decl (I've tried to trick
myself below the 80 char limit).

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Daniel Vetter 2012-07-12 20:19:59 +02:00

parent 66a9278eec

commit 08d644add0

4 changed files with 22 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/gpu/drm/i915/intel_ddi.c

View file

14

drivers/gpu/drm/i915/intel_display.c

View file

3

drivers/gpu/drm/i915/intel_drv.h

View file

41

drivers/gpu/drm/i915/intel_hdmi.c

View file