crypto: vmac - remove insecure version with hardcoded nonce

Browse source

Remove the original version of the VMAC template that had the nonce
hardcoded to 0 and produced a digest with the wrong endianness.  I'm
unsure whether this had users or not (there are no explicit in-kernel
references to it), but given that the hardcoded nonce made it wildly
insecure unless a unique key was used for each message, let's try
removing it and see if anyone complains.

Leave the new "vmac64" template that requires the nonce to be explicitly
specified as the first 16 bytes of data and uses the correct endianness
for the digest.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

...

This commit is contained in:

Eric Biggers 2018-06-18 10:22:40 -07:00 • committed by Herbert Xu

parent ed331adab3

commit 0917b87312

4 changed files with 8 additions and 186 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

crypto/tcrypt.c

View file

6

crypto/testmgr.c

View file

102

crypto/testmgr.h

View file

84

crypto/vmac.c

View file