ionic: use mutex to protect queue operations

Browse source

The ionic_wait_on_bit_lock() was a open-coded mutex knock-off
used only for protecting the queue reset operations, and there
was no reason not to use the real thing.  We can use the lock
more correctly and to better protect the queue stop and start
operations from cross threading.  We can also remove a useless
and expensive bit operation from the Rx path.

This fixes a case found where the link_status_check from a link
flap could run into an MTU change and cause a crash.

Fixes: beead698b1 ("ionic: Add the basic NDO callbacks for netdev support")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Shannon Nelson 2020-07-20 16:00:17 -07:00 • committed by David S. Miller

parent bdff46665e

commit 0925e9db4d

3 changed files with 17 additions and 25 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/net/ethernet/pensando/ionic/ionic_lif.c

View file

8

drivers/net/ethernet/pensando/ionic/ionic_lif.h

View file

6

drivers/net/ethernet/pensando/ionic/ionic_txrx.c

View file