Btrfs: Verify checksums on tree blocks found without read_tree_block

Browse source

Checksums were only verified by btrfs_read_tree_block, which meant the
functions to probe the page cache for blocks were not validating checksums.
Normally this is fine because the buffers will only be in cache if they
have already been validated.

But, there is a window while the buffer is being read from disk where
it could be up to date in the cache but not yet verified.  This patch
makes sure all buffers go through checksum verification before they
are used.

This is safer, and it prevents modification of buffers before they go
through the csum code.

Signed-off-by: Chris Mason <chris.mason@oracle.com>

...

This commit is contained in:

Chris Mason 2008-04-01 13:48:14 -04:00

parent ecbe2402cb

commit 0999df54f8

5 changed files with 60 additions and 36 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

fs/btrfs/ctree.c

View file

102

fs/btrfs/disk-io.c

View file

2

fs/btrfs/disk-io.h

View file

2

fs/btrfs/extent-tree.c

View file

1

fs/btrfs/tree-defrag.c

View file