stmmac: intel: Fix clock handling on error and remove paths

Browse source

clk_prepare_enable() might fail, we have to check its returned value.
Besides that we have to call clk_disable_unprepare() on the error and
remove paths. Do above in the dwmac-intel driver.

While at it, remove leftover in stmmac_pci and remove unneeded condition
for NULL-aware clk_unregister_fixed_rate() call.

Fixes: 58da0cfa6c ("net: stmmac: create dwmac-intel.c to contain all Intel platform")
Cc: Voon Weifeng <weifeng.voon@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Andy Shevchenko 2020-04-30 18:02:49 +03:00 • committed by David S. Miller

parent 801eb05018

commit 09f012e64e

2 changed files with 16 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

View file

5

drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c

View file