V4L/DVB (6642): xc2028: don't duplicate max_len in priv

Browse source

There is no need to duplicate the max_len field from the ctrl structure
in the private data.  If we use it directly from priv->ctrl, we can memcpy
the structure (apart from strings) to reduce maintenance as it grows.

Enforce a minimum max_len length of 8 data bytes (+ 1 address byte) as seems
to be required by the tuner.

Also, use kstrdup instead of open coding the string duplication.

Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

...

This commit is contained in:

Chris Pascoe 2007-11-19 09:29:59 -03:00 • committed by Mauro Carvalho Chehab

parent a44f1c43df

commit 0a196b6fa9

1 changed files with 16 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

37

drivers/media/video/tuner-xc2028.c

View file