xfs: pass inode number to xfs_scrub_ino_set_{preen,warning}

Browse source

There are two ways to scrub an inode -- calling xfs_iget and checking
the raw inode core, or by loading the inode cluster buffer and checking
the on-disk contents directly.  The second method is only useful if
_iget fails the verifiers; when this is the case, sc->ip is NULL and
calling the tracepoint will cause a system crash.

Therefore, pass the raw inode number directly into the _preen and
_warning functions.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>

...

This commit is contained in:

Darrick J. Wong 2017-11-06 11:46:15 -08:00

parent 35ce852334

commit 0a1e1567b3

4 changed files with 12 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/xfs/scrub/attr.c

View file

6

fs/xfs/scrub/common.c

View file

5

fs/xfs/scrub/common.h

View file

8

fs/xfs/scrub/inode.c

View file