HID: intel-ish-hid: add printf attribute to print_log()

Browse source

Structure ishtp_device contains a logging function, print_log(), which
formats some of its parameters using vsnprintf(). Add a __printf
attribute to this function field (and to ish_event_tracer()) in order to
detect at compile time issues related to the printf-like formatting.

While at it, make format parameter a const pointer as print_log() is not
supposed to modify it.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

...

This commit is contained in:

Nicolas Iooss 2016-12-22 11:09:09 +01:00 • committed by Jiri Kosina

parent f39fdf2ab8

commit 0aae34fa31

2 changed files with 4 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/hid/intel-ish-hid/ipc/pci-ish.c

View file

3

drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h

View file