__generic_file_write_iter: keep ->ki_pos and return value consistent

Browse source

A side effect worth noting: in O_APPEND case we set ->ki_pos early,
so if it turns out to be an error or a zero-length write, we'll
end up with ->ki_pos modified.  Safe, since all callers never
look at the ->ki_pos after the call of __generic_file_write_iter()
returning non-positive, all the way to caller of ->write_iter() and
those discard ->ki_pos when getting that.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

...

This commit is contained in:

Al Viro 2015-04-07 10:22:53 -04:00

parent e9d1593d4e

commit 0b8def9d6d

1 changed files with 10 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

24

mm/filemap.c

View file