ieee1394: ignore nonzero Bus_Info_Block.max_rom, fetch config ROM in quadlets

Browse source

It is already known that buggy firmwares exist which report a bogus
link_spd in their config ROM bus info block.  We now got the first
report of a bogus max_rom too (Freecom FireWire Hard Drive 1TB,
http://bugzilla.kernel.org/show_bug.cgi?id=12206).

I suspect other OSs only use quadlet reads to fetch the config ROM,
otherwise the firmware authors would have noticed their mistake.
Hence limit ieee1394's config ROM fetching routine to quadlets as the
safe minimum regardless of what the bus info block says.

This will potentially slow the bus reset handling by nodemgr somewhat
down.  But most existing devices support only quadlet reads anyway,
hence there will often be no actual difference to before this change.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

...

This commit is contained in:

Stefan Richter 2008-12-13 23:12:06 +01:00

parent c1fc58d63d

commit 0bed181968

3 changed files with 19 additions and 53 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

45

drivers/ieee1394/csr1212.c

View file

7

drivers/ieee1394/csr1212.h

View file

20

drivers/ieee1394/nodemgr.c

View file