[media] staging: go7007: fix mismatch in mutex lock-unlock in [read|write]_reg_fp

Browse source

If go7007_usb_vendor_request() fails in write_reg_fp()
or in read_reg_fp(), the usb->i2c_lock mutex left locked.

The patch moves mutex_unlock(&usb->i2c_lock) before check
for go7007_usb_vendor_request() returned value.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Alexey Khoroshilov 2012-02-13 11:01:32 -03:00 • committed by Mauro Carvalho Chehab

parent 06302ffbb4

commit 0c07aec31a

1 changed files with 10 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

drivers/staging/media/go7007/s2250-board.c

View file