sock_map: Lift socket state restriction for datagram sockets

Browse source

TCP and other connection oriented sockets have accept()
for each incoming connection on the server side, hence
they can just insert those fd's from accept() to sockmap,
which are of course established.

Now with datagram sockets begin to support sockmap and
redirection, the restriction is no longer applicable to
them, as they have no accept(). So we have to lift this
restriction for them. This is fine, because inside
bpf_sk_redirect_map() we still have another socket status
check, sock_map_redirect_allowed(), as a guard.

This also means they do not have to be removed from
sockmap when disconnecting.

Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210704190252.11866-3-xiyou.wangcong@gmail.com

...

This commit is contained in:

Cong Wang 2021-07-04 12:02:43 -07:00 • committed by Alexei Starovoitov

parent 17edea21b3

commit 0c48eefae7

3 changed files with 6 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

net/core/sock_map.c

View file

1

net/ipv4/udp_bpf.c

View file

8

tools/testing/selftests/bpf/prog_tests/sockmap_listen.c

View file