usbnet: smsc95xx: simplify tx_fixup code

Browse source

The smsc95xx_tx_fixup is doing multiple calls to skb_push() to
put an 8-byte command header onto the packet. It would be easier
to do one skb_push() and then copy the data in once the push is
done.

We also make the code smaller by using proper unaligned puts for
the header. This merges in the CPU to LE32 conversion as well and
makes the whole sequence easier to understand hopefully.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Ben Dooks 2018-11-14 11:50:20 +00:00 • committed by David S. Miller

parent 810eeb1f41

commit 0c8b26556c

1 changed files with 13 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/net/usb/smsc95xx.c

View file