pidfd: getfd should always report ESRCH if a task is exiting

Browse source

We can get EBADF from pidfd_getfd() if a task is currently exiting,
which might be confusing. Let's check PF_EXITING, and just report ESRCH
if so.

I chose PF_EXITING, because it is set in exit_signals(), which is called
before exit_files(). Since ->exit_status is mostly set after
exit_files() in exit_notify(), using that still leaves a window open for
the race.

Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Tycho Andersen <tandersen@netflix.com>
Link: https://lore.kernel.org/r/20240206192357.81942-1-tycho@tycho.pizza
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

Tycho Andersen 2024-02-07 10:19:29 +01:00 • committed by Christian Brauner

parent 83b290c9e3

commit 0c9bd6bc4b

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 20 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

kernel/pid.c

View file