iwlwifi: yoyo: don't access TLV before verifying len

Browse source

If we access the TLV memory with shorter len than the struct
we access garbage data that was not given by the user.

On the way rewrite the checker in a cleaner way.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Fixes: a9248de424 ("iwlwifi: dbg_ini: add TLV allocation new API support")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200424182644.54418c829390.I15d6b462a0e69a280b6c6cfbcb6bcb05bb5f79ee@changeid

...

This commit is contained in:

Mordechay Goodstein 2020-04-24 18:48:11 +03:00 • committed by Luca Coelho

parent f25c418dca

commit 0c9e025e79

2 changed files with 24 additions and 25 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/wireless/intel/iwlwifi/fw/api/dbg-tlv.h

View file

44

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

View file