tools/sched_ext: fix getopt() option variable signedness

Browse source

Four example schedulers (scx_simple, scx_cpu0, scx_sdt, scx_userland)
declare the variable that holds getopt()'s return value as __u32.
getopt() returns int and uses -1 to mark end-of-options; storing that
sentinel in an unsigned variable turns it into 0xffffffff, and the
subsequent 'opt != -1' test only happens to keep working because both
operands of != are promoted to the same 0xffffffff.

Declare the variable as __s32 instead, matching getopt()'s actual
contract and the style already used in scx_qmap.c (int opt) and
scx_pair/central/flatcg.c (__s32 opt). This also silences the
-Wsign-compare warnings emitted for the affected files.

Signed-off-by: Liang Luo <luoliang@kylinos.cn>
Signed-off-by: Tejun Heo <tj@kernel.org>

...

This commit is contained in:

Liang Luo 2026-06-26 17:59:28 +08:00 • committed by Tejun Heo

parent e2c60e15d0

commit 0cfd929fba

4 changed files with 4 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

tools/sched_ext/scx_cpu0.c

View file

2

tools/sched_ext/scx_sdt.c

View file

2

tools/sched_ext/scx_simple.c

View file

2

tools/sched_ext/scx_userland.c

View file