ASoC: amd: acp: Fix error handling in .remove()

Browse source

Even in the presence of problems (here: rn_acp_deinit() might fail), it's
important to unregister all resources acquired during .probe() because
even if .remove() returns an error code, the device is removed.

As .remove() is only called after .probe() returned success, platdata
must be valid, so the first check in .remove() can just be dropped.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220622061739.225966-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Uwe Kleine-König 2022-06-22 08:17:39 +02:00 • committed by Mark Brown

parent 1892a99188

commit 0deb003933

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 2 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

sound/soc/amd/acp/acp-renoir.c

View file