media: atomisp: Turn asd->streaming state tracker into a bool

Browse source

The ATOMISP_DEVICE_STREAMING_STOPPING pipe state comes from when we still
had continuous mode. This would be set when streaming from both capture +
preview devnodes when 1 of the 2 streams has been stopped and the driver
was waiting for the other stream to get stopped too.

With continuous mode gone the stopping state is no longer necessary and
asd->streaming can be changed to a bool.

Note that atomisp_assert_recovery_work() would still temporarily
set streaming to stopping, but it does so with the isp->mutex held and
changes streaming to either enabled or disabled before releasing
the mutex, so none of the consumers which care about the difference
ever see the stopping state.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

...

This commit is contained in:

Hans de Goede 2023-05-11 18:33:06 +01:00 • committed by Mauro Carvalho Chehab

parent e1278e6187

commit 0f072c1e24

7 changed files with 17 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/staging/media/atomisp/pci/atomisp_cmd.c

View file

4

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

View file

2

drivers/staging/media/atomisp/pci/atomisp_fops.c

View file

4

drivers/staging/media/atomisp/pci/atomisp_internal.h

View file

8

drivers/staging/media/atomisp/pci/atomisp_ioctl.c

View file

2

drivers/staging/media/atomisp/pci/atomisp_subdev.h

View file

2

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

View file