Merge branch 'tcp-fix-tcp_poll-races'

Browse source

Eric Dumazet says:

====================
tcp: fix tcp_poll() races

Flakes in packetdrill tests stressing epoll_wait()
were root caused to bad ordering in tcp_write_err()

Precisely, we have to call sk_error_report() after
tcp_done().

When fixing this issue, we discovered tcp_abort(),
tcp_v4_err() and tcp_v6_err() had similar issues.

Since tcp_reset() has the correct ordering,
first patch takes part of it and creates
tcp_done_with_error() helper.
====================

Link: https://lore.kernel.org/r/20240528125253.1966136-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Jakub Kicinski 2024-05-29 17:21:37 -07:00

parent c3390677f6 fde6f897f2

commit 0f4b437b5f

6 changed files with 31 additions and 37 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

include/net/tcp.h

View file

8

net/ipv4/tcp.c

View file

32

net/ipv4/tcp_input.c

View file

11

net/ipv4/tcp_ipv4.c

View file

6

net/ipv4/tcp_timer.c

View file

10

net/ipv6/tcp_ipv6.c

View file