sfc: Remove dependence on NAPI polling in efx_test_eventq_irq()

Browse source

We cannot safely assume that the NAPI handler will complete within the
20 ms that we allow for the event self-test.  The handler may be
deferred for longer than this, particularly on realtime kernels.

Instead, check whether either an event has been handled or (as in the
old failure path) whether an interrupt has been received and an event
has been delivered but not yet handled.  Use napi_disable() to
synchronize with the NAPI handler before checking, since it will
clear events before updating eventq_read_ptr.

Remove the test result chan.N.eventq.poll, since it is not an error
if the NAPI handler does not run during the test.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

...

This commit is contained in:

Ben Hutchings 2011-11-04 23:06:04 +00:00

parent cc180b69c0

commit 0fb53faa2e

3 changed files with 40 additions and 44 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/ethernet/sfc/ethtool.c

View file

79

drivers/net/ethernet/sfc/selftest.c

View file

1

drivers/net/ethernet/sfc/selftest.h

View file