netfilter: nf_flow_offload: fix use-after-free and a resource leak

Browse source

flow_offload_del frees the flow, so all associated resource must be
freed before.

Since the ct entry in struct flow_offload_entry was allocated by
flow_offload_alloc, it should be freed by flow_offload_free to take care
of the error handling path when flow_offload_add fails.

While at it, make flow_offload_del static, since it should never be
called directly, only from the gc step

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

...

This commit is contained in:

Felix Fietkau 2018-02-07 09:49:02 +01:00 • committed by Pablo Neira Ayuso

parent d8ed960058

commit 0ff90b6c20

2 changed files with 7 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

include/net/netfilter/nf_flow_table.h

View file

27

net/netfilter/nf_flow_table.c

View file