iio: trigger: free trigger resource correctly

Browse source

These stand-alone trigger drivers were using iio_trigger_put()
where they should have been using iio_trigger_free().  The
iio_trigger_put() adds a module_put which is bad since they
never did a module_get.

In the sysfs driver, module_get/put's are used as triggers are
added & removed. This extra module_put() occurs on an error path
in the probe routine (probably rare).

In the bfin-timer & interrupt trigger drivers, the module resources
are not explicitly managed, so it's doing a put on something that
was never get'd.  It occurs on the probe error path and on the
remove path (not so rare).

Tested with the sysfs trigger driver.
The bfin & interrupt drivers were build tested & inspected only.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

...

This commit is contained in:

Alison Schofield 2017-01-19 19:47:38 -08:00 • committed by Jonathan Cameron

parent 2c99f1a09d

commit 10e840dfb0

3 changed files with 7 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/iio/trigger/iio-trig-interrupt.c

View file

2

drivers/iio/trigger/iio-trig-sysfs.c

View file

4

drivers/staging/iio/trigger/iio-trig-bfin-timer.c

View file