staging: comedi: addi_apci_3xxx: fix digital input 'insn_bits' function

Browse source

This driver does not follow the comedi API. The digital input 'insn_bits'
function is supposed to return the status of all the input channels in
data[1]. Currently this function is returning the status in data[0]. It
is also unnecessarily testing the size of the return buffer.

Fix the function so it works like the comedi core expects. The core can
then use the function to emulate the 'insn_read' function for individual
channels. This allows removing the i_APCI3XXX_InsnReadDigitalInput()
function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

H Hartley Sweeten 2012-11-06 10:01:26 -07:00 • committed by Greg Kroah-Hartman

parent 141dcc33c0

commit 10f71c7845

2 changed files with 20 additions and 137 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

115

drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.c

View file

42

drivers/staging/comedi/drivers/addi_apci_3xxx.c

View file