[PATCH] s390: use normal switch statement for ioctls in dasd_ioctlc

Browse source

Add an ->ioctl method to the dasd_discipline structure.  This allows to apply
the same kind of cleanups the last patch applied to dasd_ioctl.c to
dasd_eckd.c (the only dasd discipline with special ioctls) aswell.

Again lots of code removed.  During auditing the ioctls I found two fishy
return value propagations from copy_{from,to}_user, maintainers please check
those, I've marked them with XXX comments.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

...

This commit is contained in:

Christoph Hellwig 2006-03-24 03:15:20 -08:00 • committed by Linus Torvalds

parent 13c6204fac

commit 1107ccfbde

3 changed files with 55 additions and 97 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

142

drivers/s390/block/dasd_eckd.c

View file

1

drivers/s390/block/dasd_int.h

View file

9

drivers/s390/block/dasd_ioctl.c

View file