From 1196e46f6d42ac490e245f3917af330530a176f0 Mon Sep 17 00:00:00 2001 From: Qingfang Deng Date: Sun, 20 Sep 2026 19:49:43 +0800 Subject: [PATCH] ppp_synctty: remove redundant skb null check in ppp_sync_txmunge() The skb is already dereferenced before the check. In addition, a TX skb passed from the generic layer can never be null. Remove the redundant null check. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202609132245.txZXoUxc-lkp@intel.com/ Signed-off-by: Qingfang Deng Link: https://patch.msgid.link/20260920114945.2517-1-qingfang.deng@linux.dev Signed-off-by: Jakub Kicinski --- drivers/net/ppp/ppp_synctty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ppp/ppp_synctty.c b/drivers/net/ppp/ppp_synctty.c index 9e440e110e9f..b90ae0583c84 100644 --- a/drivers/net/ppp/ppp_synctty.c +++ b/drivers/net/ppp/ppp_synctty.c @@ -464,7 +464,7 @@ ppp_sync_txmunge(struct syncppp *ap, struct sk_buff *skb) ap->last_xmit = jiffies; - if (skb && ap->flags & SC_LOG_OUTPKT) + if (ap->flags & SC_LOG_OUTPKT) ppp_print_buffer ("send buffer", skb->data, skb->len); return skb;