ovl: verify upper dentry before unlink and rename

Browse source

Unlink and rename in overlayfs checked the upper dentry for staleness by
verifying upper->d_parent against upperdir.  However the dentry can go
stale also by being unhashed, for example.

Expand the verification to actually look up the name again (under parent
lock) and check if it matches the upper dentry.  This matches what the VFS
does before passing the dentry to filesytem's unlink/rename methods, which
excludes any inconsistency caused by overlayfs.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

...

This commit is contained in:

Miklos Szeredi 2016-03-21 17:31:44 +01:00 • committed by Miklos Szeredi

parent 3c2de27d79

commit 11f3710417

1 changed files with 38 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

59

fs/overlayfs/dir.c

View file