IB/ipoib: Maintain the child_intfs list from ndo_init/uninit

Browse source

This fixes a bug in the netlink path where the vlan_rwsem was not
held around __ipoib_vlan_add causing the child_intfs to be manipulated
unsafely.

In the process this greatly simplifies the vlan_rwsem write side locking
to only cover a single non-sleeping statement.

This also further increases the safety of the removal ordering by holding
the netdev of the parent while the child is active to ensure most bugs
become either an oops on a NULL priv or a deadlock on the netdev refcount.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

...

This commit is contained in:

Jason Gunthorpe 2018-07-29 11:34:59 +03:00

parent 25405d98a2

commit 13476d35bb

3 changed files with 16 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

drivers/infiniband/ulp/ipoib/ipoib_main.c

View file

14

drivers/infiniband/ulp/ipoib/ipoib_netlink.c

View file

12

drivers/infiniband/ulp/ipoib/ipoib_vlan.c

View file