bcachefs: Improve -o norecovery; opts.recovery_pass_limit

Browse source

This adds opts.recovery_pass_limit, and redoes -o norecovery to make use
of it; this fixes some issues with -o norecovery so it can be safely
used for data recovery.

Norecovery means "don't do journal replay"; it's an important data
recovery tool when we're getting stuck in journal replay.

When using it this way we need to make sure we don't free journal keys
after startup, so we continue to overlay them: thus it needs to imply
retain_recovery_info, as well as nochanges.

recovery_pass_limit is an explicit option for telling recovery to exit
after a specific recovery pass; this is a much cleaner way of
implementing -o norecovery, as well as being a useful debug feature in
its own right.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2024-03-28 21:34:14 -04:00

parent 060ff30a85

commit 13c1e583f9

6 changed files with 26 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

fs/bcachefs/opts.c

View file

7

fs/bcachefs/opts.h

View file

10

fs/bcachefs/recovery.c

View file

12

fs/bcachefs/recovery_passes.c

View file

2

fs/bcachefs/snapshot.c

View file

5

fs/bcachefs/super.c

View file