ASoC: fsl_ssi: Redefine RX and TX macros

Browse source

The RX and TX macros were defined implicitly and there was
a potential risk if someone changes their values.

Since they were defined to index the array ssi->regvals[2],
this patch moves these two macros to fsl_ssi.c, closer to
its owner ssi->regvals. And it also puts some comments here
to limit their value within [0, 1].

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Tested-by: Caleb Crome <caleb@crome.org>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Nicolin Chen 2018-02-12 14:03:09 -08:00 • committed by Mark Brown

parent da18bcf722

commit 1476105c3f

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 4 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

sound/soc/fsl/fsl_ssi.c

View file

3

sound/soc/fsl/fsl_ssi.h

View file