tcp: Overflow bug in Vegas

Browse source

From: Lachlan Andrew <lachlan.andrew@gmail.com>

There is an overflow bug in net/ipv4/tcp_vegas.c for large BDPs
(e.g. 400Mbit/s, 400ms).  The multiplication (old_wnd *
vegas->baseRTT) << V_PARAM_SHIFT overflows a u32.

[ Fix tcp_veno.c too, it has similar calculations. -DaveM ]

Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Lachlan Andrew 2008-04-30 01:04:03 -07:00 • committed by David S. Miller

parent be9164e769

commit 159131149c

2 changed files with 11 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

net/ipv4/tcp_vegas.c

View file

8

net/ipv4/tcp_veno.c

View file