tools: ynl: check for overflow of constructed messages

Browse source

Donald points out that we don't check for overflows.
Stash the length of the message on nlmsg_pid (nlmsg_seq would
do as well). This allows the attribute helpers to remain
self-contained (no extra arguments). Also let the put
helpers continue to return nothing. The error is checked
only in (newly introduced) ynl_msg_end().

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://lore.kernel.org/r/20240305185000.964773-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Jakub Kicinski 2024-03-05 10:50:00 -08:00

parent e3afe5dd3a

commit 15d2540e0d

3 changed files with 68 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

34

tools/net/ynl/lib/ynl-priv.h

View file

36

tools/net/ynl/lib/ynl.c

View file

2

tools/net/ynl/lib/ynl.h

View file