mac80211_hwsim: Fix a possible sleep-in-atomic bug in hwsim_get_radio_nl

Browse source

The driver may sleep under a spinlock.
The function call path is:
hwsim_get_radio_nl (acquire the spinlock)
  nlmsg_new(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

...

This commit is contained in:

Jia-Ju Bai 2017-12-12 17:26:36 +08:00 • committed by Johannes Berg

parent 5d32407396

commit 162bd5e5fd

1 changed files with 1 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/wireless/mac80211_hwsim.c

View file