From 1654731536344f88e9bfbc0641e32980bf3af94e Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 22 Jul 2026 11:43:29 +0800 Subject: [PATCH] serial: 8250_bcm7271: Remove redundant dev_err_probe() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang Link: https://patch.msgid.link/20260722034342.316755-2-panchuang@vivo.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_bcm7271.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c index 742004d63c6f..cb7d594d263e 100644 --- a/drivers/tty/serial/8250/8250_bcm7271.c +++ b/drivers/tty/serial/8250/8250_bcm7271.c @@ -1099,10 +1099,8 @@ static int brcmuart_probe(struct platform_device *pdev) } ret = devm_request_irq(dev, dma_irq, brcmuart_isr, IRQF_SHARED, "uart DMA irq", &new_port->port); - if (ret) { - dev_err_probe(dev, ret, "unable to register IRQ handler\n"); + if (ret) goto err1; - } } platform_set_drvdata(pdev, priv); brcmuart_init_debugfs(priv, dev_name(&pdev->dev));