wifi: brcmfmac: fwsignal: Use struct_size() to simplify brcmf_fws_rxreorder()

Browse source

In the "struct brcmf_ampdu_rx_reorder", change the 'pktslots' field into
flexible array.

It saves the size of a pointer when the memory is allocated and avoids
an indirection when the array is used.
It also removes the usage of a pointer arithmetic and saves a few lines of
code.

Finally, struct_size() can be used. It is not a must have here, because
it is easy to see that buf_size can not overflow, but still, it is a good
practice.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/f4ca6b887ca1290c71e76247218adea4d1c42442.1721547559.git.christophe.jaillet@wanadoo.fr

...

This commit is contained in:

Christophe JAILLET 2024-07-21 09:40:19 +02:00 • committed by Kalle Valo

parent 9588469d06

commit 16b31ecb80

2 changed files with 4 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h

View file

8

drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c

View file