amd-xgbe: Tx engine must not be active before stopping it

Browse source

If the Tx engine is told to stop while it is actively processing Tx
descriptors it is possible that the Tx descriptor(s) will not be closed
out properly. When the Tx engine is restarted this could result in the
driver being stuck on the improperly closed descriptor.

Update the driver to wait for the Tx engine to be in a stopped or
suspended state before issuing the stop command.

This has not been an issue to date, but it's a good safe-guard to have.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Lendacky, Thomas 2014-11-20 11:03:32 -06:00 • committed by David S. Miller

parent 5449e27167

commit 16edd34e9e

3 changed files with 74 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/net/ethernet/amd/xgbe/xgbe-common.h

View file

59

drivers/net/ethernet/amd/xgbe/xgbe-dev.c

View file

1

drivers/net/ethernet/amd/xgbe/xgbe.h

View file