selftests/bpf: Uprobe tests should verify param/return values

Browse source

uprobe/uretprobe tests don't do any validation of arguments/return values,
and without this we can't be sure we are attached to the right function,
or that we are indeed attached to a uprobe or uretprobe.  To fix this
record argument and return value for auto-attached functions and ensure
these match expectations.  Also need to filter by pid to ensure we do
not pick up stray malloc()s since auto-attach traces libc system-wide.

Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/1649245431-29956-4-git-send-email-alan.maguire@oracle.com

...

This commit is contained in:

Alan Maguire 2022-04-06 12:43:51 +01:00 • committed by Andrii Nakryiko

parent 90db26e6be

commit 1717e24801

2 changed files with 50 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

tools/testing/selftests/bpf/prog_tests/uprobe_autoattach.c

View file

43

tools/testing/selftests/bpf/progs/test_uprobe_autoattach.c

View file