soc: ti: QMSS: Fix usage of irq_set_affinity_hint

Browse source

commit 832ad0e3da upstream.

The Keystone QMSS driver is pretty damaged, in the sense that it
does things like this:

	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));

where cpu_map is a local variable. As we leave the function, this
will point to nowhere-land, and things will end-up badly.

Instead, let's use a proper cpumask that gets allocated, giving
the driver a chance to actually work with things like irqbalance
as well as have a hypothetical 64bit future.

Cc: stable@vger.kernel.org
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Marc Zyngier 2018-10-31 08:41:34 +00:00 • committed by Greg Kroah-Hartman

parent ce65f0f625

commit 176e8d6df9

3 changed files with 22 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/soc/ti/knav_qmss.h

View file

10

drivers/soc/ti/knav_qmss_acc.c

View file

22

drivers/soc/ti/knav_qmss_queue.c

View file