scsi: ufs: hisi: fix ufs_hba_variant_ops passing

Browse source

Without CONFIG_OF, the of_match_node() helper does not evaluate its
argument, and the compiler warns about the unused variable:

drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe':
drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev' [-Werror=unused-variable]

Rework this code to pass the data directly, and while we're at it,
correctly handle the const pointers.

Fixes: 653fcb07d9 ("scsi: ufs: Add HI3670 SoC UFS driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Arnd Bergmann 2019-03-04 20:39:11 +01:00 • committed by Martin K. Petersen

parent db0f166e9a

commit 176eb92774

4 changed files with 7 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/scsi/ufs/ufs-hisi.c

View file

2

drivers/scsi/ufs/ufshcd-pltfrm.c

View file

2

drivers/scsi/ufs/ufshcd-pltfrm.h

View file

2

drivers/scsi/ufs/ufshcd.h

View file