batman-adv: Use kref_get for hard_iface subfunctions

Browse source

The callers of the functions using batadv_hard_iface objects already make
sure that they hold a valid reference. The subfunctions don't have
to check whether the reference counter is > 0 because this was checked by
the callers.

The kref_get function instead WARNs (with debug information) when the
reference counter would still be 0. This makes a bug in batman-adv better
visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>

...

This commit is contained in:

Sven Eckelmann 2016-04-11 13:06:40 +02:00 • committed by Antonio Quartulli

parent c3ba37a778

commit 17a8691502

3 changed files with 13 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

net/batman-adv/bat_iv_ogm.c

View file

7

net/batman-adv/hard-interface.c

View file

30

net/batman-adv/originator.c

View file