From 17d7aa69540822d6ef1cd47bf069213941022806 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Mon, 31 Aug 2026 09:41:58 -0700 Subject: [PATCH] netdev: don't use dev->flags for IFF_UP dev->flags are not technically ops lock protected. The IFF_UP flag will not change when dev->lock is held, but other flags may change so KCSAN would probably not be impressed. Because of this we added a dedicated dev->up which is safe to read under dev->lock. qstats want to make sure device is up, use dev->up. Reviewed-by: Bobby Eshleman Reviewed-by: Joe Damato Acked-by: Daniel Borkmann Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20260831164159.1124679-4-kuba@kernel.org Signed-off-by: Jakub Kicinski --- net/core/netdev-genl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 04dcd7fc614e..b8ba91cc93da 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -768,7 +768,7 @@ netdev_nl_stats_by_queue(struct net_device *netdev, struct sk_buff *rsp, const struct netdev_stat_ops *ops = netdev->stat_ops; int i, err; - if (!(netdev->flags & IFF_UP)) + if (!netdev->up) return 0; i = ctx->rxq_idx;