i40e: Simplify i40e_detect_recover_hung_queue logic

Browse source

This patch greatly reduces the unneeded complexity in the
i40e_detect_recover_hung_queue code path.  The previous implementation
set a 'hung bit' which would then get cleared while polling.  If the
detection routine was called a second time with the bit already set, we
would issue a software interrupt.  This patch makes it such that if
interrupts are disabled and we have pending TX descriptors, we trigger a
software interrupt since in, the worst case, queues are already clean
and we have an extra interrupt.

Additionally this patch removes the workaround for lost interrupts as
calling napi_reschedule in this context can cause software interrupts to
fire on the wrong CPU.

Change-ID: Iae108582a3ceb6229ed1d22e4ed6e69cf97aad8d
Signed-off-by: Alan Brady <alan.brady@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

...

This commit is contained in:

Alan Brady 2017-04-05 07:50:56 -04:00 • committed by Jeff Kirsher

parent 373149fc99

commit 17daabb5e8

5 changed files with 15 additions and 64 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/ethernet/intel/i40e/i40e.h

View file

1

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

View file

59

drivers/net/ethernet/intel/i40e/i40e_main.c

View file

12

drivers/net/ethernet/intel/i40e/i40e_txrx.c

View file

3

drivers/net/ethernet/intel/i40e/i40e_txrx.h

View file