drm/amdgpu/kfd: remove is_hws_hang and is_resetting

Browse source

is_hws_hang and is_resetting serves pretty much the same purpose and
they all duplicates the work of the reset_domain lock, just check that
directly instead. This also eliminate a few bugs listed below and get
rid of dqm->ops.pre_reset.

kfd_hws_hang did not need to avoid scheduling another reset. If the
on-going reset decided to skip GPU reset we have a bad time, otherwise
the extra reset will get cancelled anyway.

remove_queue_mes forgot to check is_resetting flag compared to the
pre-MES path unmap_queue_cpsch, so it did not block hw access during
reset correctly.

Signed-off-by: Yunxiang Li <Yunxiang.Li@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Yunxiang Li 2024-05-24 13:46:50 -04:00 • committed by Alex Deucher

parent 5c0a1cdd17

commit 1802b042a3

7 changed files with 45 additions and 59 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/gpu/drm/amd/amdkfd/kfd_device.c

View file

79

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

View file

1

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h

View file

11

drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c

View file

4

drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c

View file

4

drivers/gpu/drm/amd/amdkfd/kfd_priv.h

View file

4

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

View file