NFSD: Fix .pc_release method for NFSv2

Browse source

nfsd_release_fhandle() assumes that rqstp->rq_resp always points to
an nfsd_fhandle struct. In fact, no NFSv2 procedure uses struct
nfsd_fhandle as its response structure.

So far that has been "safe" to do because the res structs put the
resp->fh field at that same offset as struct nfsd_fhandle. I don't
think that's a guarantee, though, and there is certainly nothing
preventing a developer from altering the fields in those structures.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Chuck Lever 2020-10-01 18:59:44 -04:00 • committed by J. Bruce Fields

parent 7cf8357043

commit 1841b9b614

3 changed files with 26 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

fs/nfsd/nfsproc.c

View file

19

fs/nfsd/nfsxdr.c

View file

4

fs/nfsd/xdr.h

View file