[PATCH] i386: Clean up arch/i386/kernel/cpu/mcheck/p4.c

Browse source

No, just no.  You do not use goto to skip a code block.  You do not
return an obvious variable from a singly-inlined function and give
the function a return value.  You don't put unexplained comments
about kmalloc in code which doesn't do dynamic allocation.  And
you don't leave stray warnings around for no good reason.

Also, when possible, it is better to use block scoped variables
because gcc can sometime generate better code.

Signed-off-by: Zachary Amsden <zach@vmware.com>
Signed-off-by: Andi Kleen <ak@suse.de>

...

This commit is contained in:

Zachary Amsden 2007-05-02 19:27:16 +02:00 • committed by Andi Kleen

parent 959b4fdfe7

commit 18420001d6

1 changed files with 4 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

arch/i386/kernel/cpu/mcheck/p4.c

View file