sfc: Fix IRQ cleanup in case of a probe failure

Browse source

The lifetime of an irq_cpu_rmap is odd: we have to allocate it before
installing IRQ handlers and free it before removing the IRQ handlers.
As a result of this asymmetry, it was omitted from some failure paths.

On another failure path, we could try to remove IRQ handlers we
had not yet installed.

Move the irq_cpu_rmap allocation and freeing alongside IRQ handler
installation and removal, in efx_nic_{init,fini}_interrupts().
Count the number of IRQ handlers successfully installed and only
remove those on the failure path.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

...

This commit is contained in:

Ben Hutchings 2013-05-22 18:03:35 +01:00

parent e79255de85

commit 1899c111a5

2 changed files with 40 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

33

drivers/net/ethernet/sfc/efx.c

View file

45

drivers/net/ethernet/sfc/nic.c

View file