drm/msm: dpu: Move crtc runtime resume to encoder

Browse source

The crtc runtime resume doesn't actually operate on the crtc, but rather
its encoders. The problem with this is that we need to inspect the crtc
state to get the currently connected encoders. Since runtime resume
isn't guaranteed to be called while holding the modeset locks (although
it sometimes is), this presents a race condition.

Now that we have ->enabled on the virtual encoders, and a lock to
protect it, just call resume on each encoder and only restore the ones
that are enabled.

Changes in v2:
- None

Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>

Signed-off-by: Rob Clark <robdclark@gmail.com>

...

This commit is contained in:

Sean Paul 2018-11-16 13:42:22 -05:00 • committed by Rob Clark

parent fba7427eb5

commit 18a63b3c6f

5 changed files with 15 additions and 49 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

24

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

View file

6

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h

View file

24

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

View file

4

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h

View file

6

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

View file